Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1] Add KV cache group dimension to block table #12086

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[V1] Add KV cache group dimension to block table #12086

wants to merge 13 commits into from

Conversation

heheda12345
Copy link
Collaborator

@heheda12345 heheda12345 commented Jan 15, 2025 •
edited by github-actions bot
Loading

This PR adds the KV cache group (KVCacheConfig.groups introduced by #11960) dimension to block table, to prepare for supporting allocating different blocks to different layers.

It is splitted from #11938 and is a preparation for #11382

Benchmark result ($\Delta$ is compared with main branch df450aa, shows the minimum time of 3 runs, H100):
commands:

VLLM_USE_V1=1 python3 -m vllm.entrypoints.openai.api_server --port 8888 --disable-log-requests [--model facebook/opt-125m, --model meta-llama/Llama-3.2-1B-Instruct, --model meta-llama/Llama-3.1-8B-Instruct]
python $VLLM_DIR/benchmarks/benchmark_serving.py --port 8888 --ignore-eos --seed 555 --dataset-name sharegpt --dataset-path /data/zhang-chen/dataset/ShareGPT_V3_unfiltered_cleaned_split.json [--request-rate 70 --model facebook/opt-125m, --request-rate 70 --model meta-llama/Llama-3.2-1B-Instruct, --request-rate 30 --model meta-llama/Llama-3.1-8B-Instruct] --percentile_metrics='ttft,tpot,itl,e2el'

Model             E2EL(ms)   ∆E2EL(%)    ITL(ms)    ∆ITL(%)   TPOT(ms)   ∆TPOT(%)   TTFT(ms)   ∆TTFT(%)
opt-125m            437.16     +1.10%       1.87     +1.08%       1.90     +1.60%      14.92     -0.13%
llama-1b            796.35     +0.61%       3.91     +0.51%       4.00     -1.23%      24.43     -0.41%
llama-8b           2652.95     +0.00%      13.23     +0.00%      13.36     +0.00%      40.08     +1.34%

It shows that adding the group dimension does not introduce much overhead.

@heheda12345
can run
0f8a54c 
Signed-off-by: Chen Zhang <[email protected]>
@heheda12345
fix tests
990d086 
Signed-off-by: Chen Zhang <[email protected]>
@heheda12345
format
e46fff5 
Signed-off-by: Chen Zhang <[email protected]>
@heheda12345
fix bug
36a649a 
Signed-off-by: Chen Zhang <[email protected]>
@heheda12345
add comments
9c36e7d 
Signed-off-by: Chen Zhang <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@heheda12345
format
da6b549 
Signed-off-by: Chen Zhang <[email protected]>
@heheda12345 heheda12345 marked this pull request as draft January 15, 2025 15:53
heheda12345
heheda12345 commented Jan 20, 2025
View reviewed changes
vllm/v1/worker/gpu_model_runner.py
@@ -70,9 +70,7 @@ def __init__(

self.is_multimodal_model = model_config.is_multimodal_model
self.sliding_window = model_config.get_sliding_window()
self.block_size = cache_config.block_size
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get block_size from the KVCacheSpec of each group instead.

@heheda12345
update comments
cfcf2b4 
Signed-off-by: Chen Zhang <[email protected]>
@heheda12345 heheda12345 marked this pull request as ready for review January 20, 2025 08:18
@heheda12345 heheda12345 changed the title [V1][WIP] Add KV cache group dimension to block table [V1] Add KV cache group dimension to block table Jan 22, 2025
@mergify Mergify
Copy link

mergify bot commented Jan 22, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @heheda12345.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jan 22, 2025
@mergify mergify bot removed the needs-rebase label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@heheda12345